RPS in Pieces Userstyle Discussion

alms 2019-12-11 22:11:42 UTC #1

Original subject was: “Hello kind stranger who’s working on the CSS”

Any chance we can get our Discourse install upgraded? We’re like a million versions behind, and I could use the extra tools to ban hammer spammers into oblivion.

With due respect I don’t think grey on grey is the most readable combo for the edit box, tho.

BillButNotBen 2019-12-12 11:30:09 UTC #2

Is someone working on it?

If so, fixing the avatars would be good. I posted a link to how to fix them a long while back. I’ll see if i can find it.

Links in the top menu back to the main site would be good.

Imho, though others may disagree, the black forums are much nicer than the white ones. Everytime I have to read the site without logging in it burns my eyes!.

alms 2019-12-12 14:33:41 UTC #3

It dfd look like that for a while. I’m using the dark theme and it seemed to be changing while I was using the forum. The first change I noticed was the link color going, in some places, from light blue to “nu-RPS green”, so to speak (in others, it didn’t). Then I spotted the edit pane change screenshot’ted above.

While most of the RPS technical staff and admins haven’t seemingly logged in since years, there were a few other changes, mostly minor, deployed in a quiet and stealthy fashion.

If you can use Stylus, there is a very nicely made dark theme that puts an end to the retina-searing all-white design of the main site.

BillButNotBen 2019-12-12 14:37:30 UTC #4

strangely, I don’t seem to mind the whiteness on the main site. But on the forums…

BlankedyBlank 2020-01-03 21:18:18 UTC #5

Do you use the UserStyles/Stylus theme? I think you might do - you posted this 23d ago and I last updated it on the 11th of December.

I made the RPS in Pieces theme, and when I came back to use the forums for the RPS Advent Calendar Guessing Game I finally got around to giving the forum CSS a pass-over. You can always check when and what I’ve updated on the theme’s UserStyles page: https://userstyles.org/styles/162650/rps-in-pieces-new-dark-mode

I noticed the avatar issue earlier today as well, unfortunately it’s not something I can fix in CSS (though I could with a GreaseMonkey script, and I was considering writing one to replace images on the main site with their full quality versions because the artefacting bugs the hell out of me).

I quite like the low contrast grey-on-grey edit box but if you feel it is too unreadable I could increase it.

Changes still to make: buttons at bottom of threads, buttons underneath timeline slider, buttons at bottom of post on moueover, smiley popup by edit box, visited link colour, notification panel, quote popup when text highlighted, profile activity page.

BlankedyBlank 2020-01-03 22:06:19 UTC #6

Script to fix the avatar issue on the forums: https://greasyfork.org/en/scripts/394599-rps-forum-avatar-fixer

Install with GreaseMonkey (FF) or TamperMonkey (Chrome).

Edit: doesn’t work when things are revealed after initial page load, i.e. profile “activity” feed, on expanding “like” area, when posts are loaded by scrolling on threads. Needs tweaking, possibly waiting for XHRs to run again. You can see it does work initially by F5ing e.g. this thread. Will update within the week.

alms 2020-01-04 02:44:03 UTC #7

Thank you for you work, I love that style. It did not occur to me that the CSS extended to the forum, as this has never been the case with the ones I’ve used over the years.

I can see why you like it, but it is a bit low contrast. Not too unreadable (I got used to it alright), but it may be kind of erring on the side of too much of a good thing, IMHO, if that makes sense.

BlankedyBlank 2020-01-05 10:38:06 UTC #8

You’re welcome! I think I got too burnt out on the masses of CSS required to come back and finish the forum part after doing everything required for the main site.

What would you suggest, colour-wise? Lighter text, or darker edit box? I won’t bias your opinion by stating mine first

Speaking of low contrast, I think the “visited” links on the forum are too dark (purple) to stand out against the background. Would you agree?

If you notice anything that looks out of sorts, or stuff being changed in one place but not in another, please do let me know.

alms 2020-01-05 16:34:26 UTC #9

Perhaps I’d try darker greys for both the edit box itself and the surrounding pane.

I’m not seeing any dark purple topic titles? I do have some that are light blue, while most are light grey.

The unread count bubble background is also light blue, as is all accenting in the dropdown menus.

BlankedyBlank 2020-01-06 01:03:25 UTC #10

Excellent, that’s what I’ve gone for on my ~~local~~ update. It now passes Web Content Accessibility Guidelines for normal-sized text (a contrast ratio of >4.5).

I’ve found the source of the difference between our experiences - I have actually made my changes based on the ‘Default’ theme, and some of the elements must have different class identifiers on the ‘Dark’ theme - so my CSS does not apply to everything as it should.

I’ve pushed out an update to the theme to address some things in my previous list:

Profile activity pages are the main ones still to go. Some (visited) link colours may remain unchanged; changing them from the default is an individual process as I want the theme to operate across the forum and the main site - I don’t want to accidentally change any colours there by doing a global swap.

At some point I may go back and add the correct CSS selectors for the ‘Dark’ theme to be styled the same, but for now the full RPS in Pieces forum styling only works on ‘Default’.